[Freeciv-Dev] Re: [PATCH] Map cleanups (PR#1208)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Jan 07, 2002 at 01:18:57AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> Ross W. Wetmore wrote:
> 
> > At 03:45 PM 02/01/06 +0100, Raimar Falke wrote:
> >>On Sun, Jan 06, 2002 at 04:32:02AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx 
> >>wrote:
> >>>Ross W. Wetmore wrote:
> 
> >>>Then we have the following comments for normalize_map_pos:
> >>>   +FIXME: This should test for realness using is_real_tile() before 
> >>>touching
> >>>   +       coordinates and update only if needed, thus avoiding side 
> >>>effects.
> >>>
> > 
> >>>normalize_map_pos() has _inherent_ side effects, and trying to pretend 
> >>>otherwise is foolishness IMO.
> >>>
> > 
> > Clearly you haven't looked at the (whole) patch. Side effects have been 
> > removed from the current CVS bringing them into line with the original
> > corecleanup. "_inherent_" is another of those mental religious terms
> > not founded in reality here :-).
> 
> The "side effects" are that x and y are changed if they are real and 
> non-normal.  I am in favor of making normalize_map_pos _not_ change x 
> and y if they're unreal (as you say, some parts of the code assume 
> this), but against making it a defined part of the interface.  But I 
> don't think it's a sticking point; we'll call this a skirmish.

Ok I now understand what Ross wants. So this looks like we have to
review all normalize_map_pos calls.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Any sufficiently advanced technology is indistinguishable from magic."
    -- Arthur C. Clarke