[Freeciv-Dev] Re: Military amortize (PR#1196)
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
--- Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> wrote:
> This is a mass reply to your comments.
> First of all, thanks for your time!
>
> To Raahul: Renaming variables like "e" should be done in one big renaming
> sweep IMHO, by you, or Petr, or myself, or whoever. I wanted to keep the
> patches small :)
>
Fair enough. If you or Petr are not already planning to do it, I will attend
to it.
> To Ross: I thought about making amortize and then military_amortized use
> a lookup table. It can (and should) be done in next patches. In any
> case, amortize is potentially buggy: on one hand it uses predefined MORT
> which can be changed elsewhere. On the other hand it implicitly assumes
> that MORT == 24 (in (23/24)^12 == 3/5 speedup).
Evil. Go ahead and fix this.
__________________________________________________
Do You Yahoo!?
Send FREE video emails in Yahoo! Mail!
http://promo.yahoo.com/videomail/
|
|
