Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2001:
[Freeciv-Dev] Re: Cleaning up find_a_direction. (PR#1132)
Home

[Freeciv-Dev] Re: Cleaning up find_a_direction. (PR#1132)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx
Cc: bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Cleaning up find_a_direction. (PR#1132)
From: Raahul Kumar <raahul_da_man@xxxxxxxxx>
Date: Thu, 13 Dec 2001 17:19:33 -0800 (PST)

--- Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> wrote:
> This is extensive cleanup of find_a_direction function from gotohand.c
> A lot of variable renaming (from a,b,c to more meaningful names),
> commenting, putting braces in ifs.
> 
> The only significant change in the fabric of the code is trying to make
> triremes safer at sea.  The previous implementation didn't work at all,
> now it works if warmap is generated in the right way (it isn't, but
> that's will be fixed in future patches).  Even if warmap is "wrong", the
> trireme is saved if there is a coast nearby.

<snip>

Thanks for the variable renaming. Does this apply everywhere in the code? Has
Syela been consistent? 


__________________________________________________
Do You Yahoo!?
Check out Yahoo! Shopping and Yahoo! Auctions for all of
your unique holiday gifts! Buy at http://shopping.yahoo.com
or bid at http://auctions.yahoo.com


[Prev in Thread] Current Thread [Next in Thread]