Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2001:
[Freeciv-Dev] Re: PATCH: LOAD_MAP_DATA
Home

[Freeciv-Dev] Re: PATCH: LOAD_MAP_DATA

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Thue <thue@xxxxxxx>
Cc: freeciv-dev <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: PATCH: LOAD_MAP_DATA
From: Jason Dorje Short <vze2zq63@xxxxxxxxxxx>
Date: Sat, 13 Oct 2001 05:00:44 -0400
Reply-to: jdorje@xxxxxxxxxxxx

Thue wrote:
> 
> On Saturday 13 October 2001 08:46, Raimar Falke wrote:
> > > Oh, one other thing: some of the current (CVS) code skips over map
> > > lines that don't exist.  The LOAD_MAP_POS macro doesn't do this,
> > > instead it asserts that the line exists and then continues blindly.
> > >  I don't know if it's actually necessary to skip empty lines
> > > (presumably it's a backwards-compatibility thing), but I think
> > > another parameter, force, needs to be added to the macro that will
> > > control this.
> >
> > Thue? Is it needed to skip empty lines?
> 
> I don't know why it does that.

Partial results from CVS annotate:

1.1          (thue     25-Aug-00):     if (terline) {
1.1          (thue     25-Aug-00):     if (terline) {
1.1          (thue     25-Aug-00):     if (terline) {
1.1          (thue     25-Aug-00):       if (terline) {
1.1          (thue     25-Aug-00):       if (terline) {
1.1          (thue     25-Aug-00):       if (terline) {

But the CVS log at the time shows:

revision 1.1
date: 2000/08/25 20:15:30;  author: thue;  state: Exp;
Add the savegame.[ch] module.

So, in summary it will be very hard to track down the actual author.

jason


[Prev in Thread] Current Thread [Next in Thread]