[Freeciv-Dev] Re: [Patch] Convert all the code to use map_inx

[Gaute B Strokkenes <gs234@xxxxxxxxx>]

On Tue, 09 Oct 2001, vze2zq63@xxxxxxxxxxx wrote:
> Raimar Falke wrote:
>> 
>> Subject says all hopefully.
> 
> Looks clean to me.
> 
> The only issue is with the capitalization of the macros - in theory
> both hmap and rmap should be all-caps.

No.  The only case where you really should use an upper case name for
a function-like is when the macro does not evaluate each of its
arguments exactly once.  In other cases, it's a toss-up.  Since these
macros return rvalues I would prefer upper case, but clearly
reasonable people may disagree on this.

> But you don't change most of the hmap uses at all, and rmap is right
> next to it, so I'm not sure what would be correct here.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
ONE:  I will donate my entire ``BABY HUEY'' comic book collection
 to the downtown PLASMA CENTER..
 TWO:  I won't START a BAND called ``KHADAFY & THE HIT SQUAD''..
 THREE:  I won't ever TUMBLE DRY my FOX TERRIER again!!