[Freeciv-Dev] Re: [Patch] Extended connect dialog (PR#977)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Oct 01, 2001 at 03:21:00PM +0200, Andreas Kemnade wrote:
Content-Description: message body text
> Here is a new version of the patch. 
> I hope all the issues mentioned before are fixed.
> connectdlg_g.h is extended and contains some new functions.
> 
> This patch is only for the gtk client. I will do the stuff for the
> win32 client. 
> I haven't done xaw and mui development for a long time, so I can only
> provide stubs (and call gui_server_connect() in popup_main_menu).

 - WNOHANG wasn't defined in client/gui-gtk/connectdlg.c
 - in the connect dialog should be a "Back" button
 - I think that the control logic should be in a client/*.c file with
 specific gui depended callbacks. Or put the fork/wait/pipe code into common.

Do any other people have comments?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "brand memory are for windows users that think their stability
   problems come from the memory"
    -- bomek in #freeciv