Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2001:
[Freeciv-Dev] Re: [FreeCiv-Cvs] rfalke: Remove public use of DIR_D[XY].
Home

[Freeciv-Dev] Re: [FreeCiv-Cvs] rfalke: Remove public use of DIR_D[XY].

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [FreeCiv-Cvs] rfalke: Remove public use of DIR_D[XY]. This is done...
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 23 Sep 2001 21:55:27 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Sun, Sep 23, 2001 at 09:11:02AM -0700, freeciv@xxxxxxxxxxxxxxxxxxx wrote:
> This is an automated notification of a change to freeciv cvs, 
> on Sun Sep 23 09:09:35 PDT 2001 = Sun Sep 23 16:09:35 2001 (GMT)
> by Raimar Falke <rf13@xxxxxxxxxxxxxxxxxxxxxx>
> 
> ---- Files affected:
> 
> freeciv/client goto.c tilespec.c
> freeciv/client/gui-gtk mapview.c
> freeciv/client/gui-mui graphics.c mapclass.c
> freeciv/client/gui-win32 mapview.c
> freeciv/client/gui-xaw mapview.c
> freeciv/common map.c map.h
> freeciv/server gotohand.c
> 
> ---- Log message:
> 
> Remove public use of DIR_D[XY]. This is done by 
>  - converting "for (dir = 0; dir < 8; dir++) { x1 = x + DIR_DX[dir];
>  y1 = y + DIR_DY[dir]; if (!normalize_map_pos(&x1, &y1)) continue;"
>  with "adjc_dir_iterate(x, y, x1, y1, dir) {"
>  - converting the remaining instance to use DIRSTEP or MAPSTEP.
> 
> DIRSTEP is now the only remaining code which uses DIR_D[XY].
> 
> Original idea of MAPSTEP from Gaute B Strokkenes
> <gs234@xxxxxxxxx>. Patch by me.

We can get rid of void_tile since there are now no more map accesses
with un-real positions.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 A life? Cool! Where can I download one?

Attachment: void_tile_remove.diff
Description: Text document


[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: [FreeCiv-Cvs] rfalke: Remove public use of DIR_D[XY]. This is done..., Raimar Falke <=