Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2001:
[Freeciv-Dev] Re: Corrected code
Home

[Freeciv-Dev] Re: Corrected code

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Raahul Kumar <raahul_da_man@xxxxxxxxx>
Cc: freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: Corrected code
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 23 Sep 2001 14:52:47 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Sun, Sep 23, 2001 at 05:22:54AM -0700, Raahul Kumar wrote:

[ Still no quotes ]

>  What about replacing the three lines above with:
>    for (i = 0; i < (pcity->ppl_scientist -
>  result->scientists); i++) {
>  
>  No extra variable. No extra if.
>  
> Not bad, but I like to create code that all fits on
> one line. I find it harder to read code that splits
> across
> two lines, and I wanted to make the code self
> documenting like you have. Nonetheless, you're
> recommended changes 
> are attached to this email. Does this finally wrap up
> apply_result_on_server? 

It is ok. Although it would be nice to get a diff the next time.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Any sufficiently advanced technology is indistinguishable from magic."
    -- Arthur C. Clarke


[Prev in Thread] Current Thread [Next in Thread]