[Freeciv-Dev] Re: [PATCH] Cleaned up magic codeingotohand.c (PR#944)

[Jason Dorje Short <jshort@xxxxxxxxxxxxx>]

"Ross W. Wetmore" wrote:

> Not quite. You need to apply the algorithm interatively, and this
> makes the example you have below impossible without saving the initial
> position as well as leading you astray in understanding mine.

I understand.  You're right, though, your algorithm will go something
like:

X
 *
  *
   **
     **
       **
         Y

So it should actually give the exact same results as my diagram for that
particular input.  Ideally, though, we'd have something like:

X
 *****
      *****
           *****Y

Instead of

X*************
              **
                Y

You claim this requires information about the initial location of the
unit.  I do not believe this is strictly true; I think it is possible to
do better than your algorithm without such information.  But I'm not
prepared to offer an algorithm that achieves this :-).  Anyway, it is a
small issue compared to the improvement your algorithm provides.

jason