[Freeciv-Dev] Re: [FreeCiv-Cvs] rfalke: Cleanup: replace "sizeof(x)/sizeof(x[0])" wi...

[Justin Moore <justin@xxxxxxxxxxx>]

> > > Cleanup: replace "sizeof(x)/sizeof(x[0])" with a new macro
> > > ARRAY_SIZE.
> > >
> >
> > This is a very good idea, but I think the name should be ARRAY_LEN to
> > since the value returned is the number of elements, rather than
> > something you can pass to malloc().
>
> This is exactly what I feared: a long discussion about the name of the
> thing. Experience told us that the discussion will not come to a
> consensus. So I just applied it. If you find the name wrong lets
> discuss this in a long thread and IF there is a consensus you have
> just to s/ARRAY_SIZE/ARRAY_LEN/.

   I actually agree with Gaute on this one.  Size is something that gets
passed to malloc, and length is the number of elements in an array.  I
would see ARRAY_SIZE as:

#define ARRAY_SIZE(x) sizeof(x)

where 'x' just happens to be, well, an array. :)

-jdm (also hoping this won't turn into another prolonged discussion)

Department of Computer Science, Duke University, Durham, NC 27708-0129
Email:  justin@xxxxxxxxxxx