Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: [PATCH] Corecleanup_07Part1 has been putin incoming

[Freeciv-Dev] Re: [PATCH] Corecleanup_07Part1 has been putin incoming

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Jason Dorje Short <jshort@xxxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] Corecleanup_07Part1 has been putin incoming
From: "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>
Date: Mon, 27 Aug 2001 02:22:35 -0400

At 06:02 PM 01/08/26 -0400, Jason Dorje Short wrote:
>"Ross W. Wetmore" wrote:
>> No! DIR8_NORTH links this to the core direction system which might change.
>> ttype_north has been used to isolate the changes to just the early section.
>This code in client/tilespec.c is not tied to the GUI directional
>system.  In fact, right now it uses the DIR_DX2 (rotational) system, and
>should be schema-independent if the magic numbers are removed.  Using
>the core directional system is IMO the right way to handle this.

There still is no need to use the direction enums. The code was written
to make one local spot the only place where things needed to match up.
Add enums, and you have to make two spots match up, or 3 or 4. 

But to keep you happy look at Part3 :-).


[Prev in Thread] Current Thread [Next in Thread]