[Freeciv-Dev] buglet with map_canvas_store_twidth

[Jason Dorje Short <jshort@xxxxxxxxxxxxx>]

In mapview.c in the gtk client y is iterated over the width of the map
view.  It seems clear that this should be iterated over the height
instead:

http://www.freeciv.org/lxr/source/client/gui-gtk/mapview.c?v=cvs#L1554

A search shows similar things in several places elsewhere:

http://www.freeciv.org/lxr/search?v=cvs&string=y.*map_canvas_store_twidth
http://www.freeciv.org/lxr/source/client/gui-gtk/mapview.c?v=cvs#L313
http://www.freeciv.org/lxr/source/client/gui-xaw/mapview.c?v=cvs#L107
http://www.freeciv.org/lxr/source/client/gui-mui/mapview.c?v=cvs#L455

Without a comment of any sort I doubt this is intentional.  This is the
non-isometric code, so things seem straightforward.

A test confirms that if you make the window much wider than it is tall,
city names will be cut off at the bottom (this with current CVS,
unmodified).

jason