[Freeciv-Dev] Re: [PATCH] Small improvement at genlist and maphand

[Gaute B Strokkenes <gs234@xxxxxxxxx>]

On Mon, 20 Aug 2001, xyzzy@xxxxxxxxxxxxx wrote:

>> int get_player_by_id(struct player *pplayer)
>> {
>>     assert(pplayer->player_no >= 0 && pplayer->player_no <
>>     game.max_players); return pplayer->player_no;
>> }
> 
> This function really makes no sense.  What is that assert checking?
> That the player structure pointed to really points to a player
> structure?  It's acceptable to de-reference a player pointer to get
> at the fields, no need to create accessor functions for everything.

I think the idea is to get an immediate core dump when pplayer is bad,
rather than funny errors further down because pplayer->player_no does
not make sense.

But I agree that this is not necessary.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
Did YOU find a DIGITAL WATCH in YOUR box of VELVEETA?