[Freeciv-Dev] Re: [PATCH] more small directional cleanups

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Aug 20, 2001 at 09:03:20AM -0400, Jason Dorje Short wrote:

_I_ like the patches been posted to freeciv-dev.

> Unfortunately, I appear to have missed at least one instance of "magic"
> code to handle the directional system in my previous patch.  A new patch
> fixes this, as well as cleaning up new magic code that I introduced:
> ftp://ftp.freeciv.org/freeciv/incoming/dir-patch2-1.diff.

Looks good. Can the do while loop get a counter which bails out after
say 1000 iterations? There is the currently unthinkable case of
(x0,y0) are one a realness isle. But the list is discussing topologies
which are weird I want just to be sure.

> A follow-up to this patch replaces and unifies the current directional
> system by using the DIR_DX2 system instead of the current (DIR_D[XY])
> (and removing DIR_D[XY]2 in the process):
> ftp://ftp.freeciv.org/freeciv/incoming/dir-patch3-1.diff.

Could you adapt the MAPSTEP() macro from Gaute. Maybe also as a
function?

> Yet another tiny patch replaces a few simple instances of
> map_adjust_x/map_adjust_y with normalize_map_pos.  I've had this one
> sitting around for a while, but nobody else's changes seem to have been
> committed yet so here it is:
> ftp://ftp.freeciv.org/freeciv/incoming/dir-patch4-1.diff.  (It's a bit
> of a misnomer.)

I would like to see
  /* check if there is enemy nearby */
  for(x = punit->x - 3; x < punit->x + 4; x++)
    for(y = punit->y - 3; y < punit->y + 4; y++) {
replaced with a *_iter macro.

Instead of replacing map_adjust_x/map_adjust_y with normalize_map_pos
I would like to see in the medium term a call to
ensure_real_and_normalized_position();

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx