[Freeciv-Dev] Re: civserver -r does not work properly. (PR#878)

[Reinier Post <rp@xxxxxxxxxx>]

On Sun, Aug 12, 2001 at 04:24:12PM +0200, Gaute B Strokkenes wrote:

> >> The -r option reads the file sooner than a /read command or manual
> >> entry:
> >> 
> >>    http://www.freeciv.org/lxr/source/server/srv_main.c?v=cvs#L178
> >> 
> >> The server hasn't even read the savefile at that point (if -f is
> >> used).  Executing -r should be delayed until a server command
> >> prompt appears.  /start will work and /create will no longer appear
> >> to work when -f is used.
> >> 
> >> If both -r and -f are used, which will take precedence in case of
> >> conflicts?  This is important if server options are saved to the
> >> savefile.  I don't recall a statement of policy regarding whether
> >> they ought to be.
> > 
> > Attached is a patch to invert this, making -r equivalent to a /read
> > as the first command.
> 
> This looks fine to me, but what are the consequences of this
> re. scenarios?  Why does not /create work?  Does it affect aifill too?
>
> If this makes it impossible to load e.g. the earth scenarios and start
> a game with lots of AIs, then that's bad.

I just tried, and this is what I got.  It looks OK to me.
Am I missing something?

% cat ~/.freeciv/create.serv
create ai
create bi
set timeout 90
set aifill 15
start
% civserver -f `pwd`/data/scenario/europe-200x100-v2.sav -r 
~/.freeciv/create.serv
This is the server for Freeciv version 1.11.12 (beta version)
You can learn a lot about Freeciv at http://www.freeciv.org/

THIS IS A BETA VERSION
Freeciv 1.12.0 will be released in
August, at http://www.freeciv.org/

2: Loading saved game: /tmp/rp/f-r-swapc/data/scenario/europe-200x100-v2.sav
2: Loading rulesets
2: Now accepting new client connections.
2: ai has been added as an AI-controlled player.
Created new AI player: ai.
2: bi has been added as an AI-controlled player.
Created new AI player: bi.
Option: timeout has been set to 90.
Option: aifill has been set to 15.
Starting game.
2: Loading rulesets
2: AI is controlling the Romans ruled by ai.
2: AI is controlling the Canadians ruled by bi.
2: Maxplayers smaller than aifill; aifill reduced to 14.
2: Urho Kekkonen has been added as an AI-controlled player.
2: AI is controlling the Finns ruled by Urho Kekkonen.
Urho Kekkonen is now normal.
2: David Ben-Gurion has been added as an AI-controlled player.
2: AI is controlling the Israelis ruled by David Ben-Gurion.
David Ben-Gurion is now normal.
2: Mutsuhito has been added as an AI-controlled player.
2: AI is controlling the Japanese ruled by Mutsuhito.
Mutsuhito is now normal.
2: Ly Bon has been added as an AI-controlled player.
2: AI is controlling the Vietnamese ruled by Ly Bon.
Ly Bon is now normal.
2: Christine has been added as an AI-controlled player.
2: AI is controlling the Swedes ruled by Christine.
Christine is now normal.
2: Petlura has been added as an AI-controlled player.
2: AI is controlling the Ukrainians ruled by Petlura.
Petlura is now normal.
2: Palmiro Togliatti has been added as an AI-controlled player.
2: AI is controlling the Italians ruled by Palmiro Togliatti.
Palmiro Togliatti is now normal.
2: Lincoln has been added as an AI-controlled player.
2: AI is controlling the Americans ruled by Lincoln.
Lincoln is now normal.
2: Sergio Osmena has been added as an AI-controlled player.
2: AI is controlling the Filipinos ruled by Sergio Osmena.
Sergio Osmena is now normal.
2: Owain Glyndwr has been added as an AI-controlled player.
2: AI is controlling the Welsh ruled by Owain Glyndwr.
Owain Glyndwr is now normal.
2: Afonso Henriques has been added as an AI-controlled player.
2: AI is controlling the Portuguese ruled by Afonso Henriques.
Afonso Henriques is now normal.
2: Valdemar den Store has been added as an AI-controlled player.
2: AI is controlling the Danes ruled by Valdemar den Store.
Valdemar den Store is now normal.

For introductory help, type 'help'.
> create ci     
Can't add AI players once the game has begun.
> 
Game saved as civgame-3950.sav
> 

-- 
Reinier