[Freeciv-Dev] Re: Profiling Civserver again

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

Thanks for the feedback.

At 10:26 PM 01/07/31 -0400, =?BIG5?B?vbKr7bXY?= wrote:
>Seems like the patch inflates mapgen.c from ~61K to ~98K.
>Of course, some of the macro definitions don't belong there.
Yes, they need to get into map.h. But for testing purposes
it was safer and less pervasive to keep them local to mapgen.

>Sometimes, code simplicity is more important than speed.
>Not sure if it is worth going in this extreme for speed.
>Mapgen is only called once per game after all.
>However, there are redundant checks which should have been removed.
>Another thing to consider is memory consumption,
>speeding up the computation at the expense of memory can cause additional
>memory swap which slows down everything even more.
Can you give linenumbers or examples for these?

>Regards,
>I.Q.

Cheers,
RossW