[Freeciv-Dev] Re: Server confused about war and attack states (PR#791)

[Thue <thue@xxxxxxx>]

On Wednesday 30 May 2001 21:42, Christian Knoke wrote:
> Version: 1.11.4 / CVS of 30 May 2001
> System:  Linux i386 GTK+
>
> This is a very funny one. It has been discovered
> by a friend, so I can't tell you much about the
> game, except that it is originating from a 1.11.4
> server, but the bug is reproducible on 1.11.4 and
> CVS.
>
> Savegame is here:
> http://www.enter.de/~c.knoke/bugs/no-attack.sav.gz
>
> Login as gast and attack the Portuguese capital
> Lisboa. Use a stealth bomber from Setubal or a
> helicopter. Server refuses to attack, saying
> "Game: No war declared against João II, cannot attack"
> (There IS war). Debug says:
> ------
> 1: Get_def bugged at (56,19). The most likely course
> is a unit on an ocean square without a transport.
> The owner of the unit is João II
> -----------
>
> Then use a tank or howitzer to attack and destroy
> the ship inside Lisboa. After that, you can enter
> the city with either tank or helicopter.
>
> Christian

Cute; the AI appears to be full of integer overflows. This one is in
rate_unit_d and happens when val=54000 is squared.

No wonder the AI sometimes messes up in it's calculations with the strongest 
units.

-Thue