[Freeciv-Dev] Re: (GCC errors)7 patches to freeciv-1.11.4 (3rd try)

[Dirk Stoecker <stoecker@xxxxxxxx>]

On Mon, 26 Feb 2001, Thue wrote:

> Well, language syntax should not be decided by what broken compiler ships 
> with the latest release.
> A good reason one way or the other would be the C99 standard (there are so 
> many C enthusiasts on this list who will jump on this one, so I will just 
> leave it to them to battle it out for the correct syntax).
> Anyway the redhat 7 people can compile with kgcc.

[...]

>       This patch makes common/log.h work with gcc 2.96, which is great if you
>       want to compile under 2.96, but REALLY BAD if you are using an earlier
>       version of gcc.  Probably THESE MACRO DEFINITIONS SHOULD HAVE MORE #if'd
>       VARIANTS ... but I don't know which version(s) of gcc require which
>       syntax.  Is there an autoconf test for this?  Sorry, but a proper patch
>       for this problem is beyond my current expertise.

AARRRRGGGGGHHHH.
It would be fine if my log.h patch would be applied sometimes.

- Fixes strange warnings, if freelog is unused.
- Does not produce unused code.
- Makes above obsolete
- Allows to use the debug-freelog system with non-GCC compilers
- looks much smarter than current form
- ...

And jjm can't really tell me a reason, why he does not do so.

Ciao
 ____  _ _  ____  _ _    _ _  ____
|    |  |  |    |  | \  / |  |    | the cool Gremlin from Bischofswerda
|  __   |   ____|  |  \/  |  |    | WWW: http://home.pages.de/~stoecker/
|    |  |  |       |      |  |    | PGP key available on www page.
|____| _|_ |____| _|_    _|_ |____| I hope AMIGA never stops making fun!