[Freeciv-Dev] Re: PATCH: mapgen warning removes

[Falk Hueffner <falk.hueffner@xxxxxxxxxxxxxxxxxxxxxxxx>]

Dirk Stoecker <stoecker@xxxxxxxxxxxxxx> writes:

> -static void makeisland(int islemass, int starters)
> +static void makeisland(long islemass, int starters)
>  {
>    static long int tilefactor, balance, lastplaced;/* int may be only 2 byte 
> ! */

I'm sure it is assumed at about a gazillion places that int is at
least 4 bytes. Please, let's rather document this and not uglify the
code with weird "longs" scattered about the place which make the code
behave bad on 64 bit architectures. (Yes, I have encountered *many*
such problems.)

        Falk