[Freeciv-Dev] Re: [PATCH] The Freeciv motto. (PR#547)

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/09/03 13:20 , Gaute (B) Strokkenes wrote:
>Jeff Mallatt <jjm@xxxxxxxxxxxx> writes:
>
>> At 2000/09/03 09:25 , Gaute (B) Strokkenes wrote:
>> >
>> >This patch replaces the function freeciv_motto() in common/shared.c
>> >with an equivalent string in client/climisc.c.  Updates the gtk and
>> >xaw clients; other clients should be trivial.  Tested on the xaw
>> >client.
>> 
>> I prefer the way it is.  What reason(s) do you propose for making
>> this change?
>
>1) This is (gui-independent) client-only code, not common code.
>   Therefore, it belongs in client/ rather than common/, not so much
>   because of the bloat but because it makes the code harder to
>   understand.

Is the server not part of Freeciv?  Should we go through every file in
common and move functions out which happen to only be called by either the
server of the clients?

>2) There is absolutely no reason why the motto needs to be wrapped in
>   a function.  It's not done that way anywhere else in Freeciv, and
>   there's no reason to do it that way here.  If the motto needs to be
>   changed you can change the string as easily in climisc.c as you
>   could within a function.  Unless I am gravely mistaken, there will
>   not be any need to generate the motto on the fly, either.  Again,
>   the issue is not the bloat, but the added complexity.

To me, the function isolates complexity, and makes the calling code cleaner.

jjm