[Freeciv-Dev] Re: 'Report' menu

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/08/30 12:01 , Thue wrote:
>On Mon, 21 Aug 2000 21:29:43 Erik Sigra wrote:
>> Reinier Post wrote:
[snip]

There were many problems with this patch.  I may not have found everything,
but I did address the following:

* general:

- patch didn't apply cleanly, but for no obvious reason
- required changes to mui and stub clients because of renamed functions

* xaw:

- trade report resources renamed in code, but not in resource file
- key bindings for units report incorrectly named in resource file
- cities report top label "City Advisor" -> "Cities"
- economy report top label "Economy Advisor" -> "Economy"
- science report dialog title "Science Report" -> "Science"
- science report top label "Science Advisor" -> "Science"
- fix bug made noticeable by this label change
- action routines are organized in alphabetical order

* gtk:

- fixed formatting of menus struct broken by this and other patches
- gave View/City Names missing short-cut of N
- weird short-cut assignments changed to first letters
- short-cut collision between Message Options and Messages on Game fixed
- short-cut collision between Wake up others and Make Homecity on Orders fixed
- short-cuts don't work if any collision, even if disabled
  (i assigned what i could think of; some remain unassigned)
- dynamic menu items now work with short-cuts
- cities report dialog title "City Report" -> "Cities"
- cities report top label "City Advisor" -> "Cities"
- configure cities report top label "Configure City Report" -> "... Cities
..."
- economy report top label "Economy Advisor" -> "Economy"
- science report dialog title "Science Report" -> "Science"
- science report top label "Science Advisor" -> "Science"

menus-1.diff.gz
Description: Binary data

jjm