[Freeciv-Dev] patch: use LOG_ERROR (PR#503)

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

This patch changes some freelog() calls to use new level LOG_ERROR.
- Majority are LOG_NORMAL -> LOG_ERROR and straightforward.
- Some are LOG_FATAL -> LOG_ERROR, for cases which are not really 
fatal.  (Ie, cases not followed by exit() or abort() or similar.)
- Some are LOG_VERBOSE and LOG_DEBUG -> LOG_ERROR where I thought 
it was warranted (ie, previous level was wrong IMO).
- Maybe some other small related changes?

Removed gettext markings on some marked strings, where I thought
it was inappropriate, specifically:
civclient.c: "Received unknown packet from server!"
diplhand.c: "Treaty city id %d not found - skipping clause."
plrhand.c: "Message truncated in page_conn_etype!"
ruleset.c: "Bad value %i for min_dist_bw_cities. Using 2."
        "Bad value %s for hut_overflight. Using \"Frighten\"."
        "Bad value %s for nuke_contamination. Using \"Pollution\"."

Rationale: Messages which are only of use to developers (including
modpack/ruleset developers) shouldn't be translated, because such 
developers need to known English anyway, or other people seeing these
should send them as bug reports, and as such they are better in English.
(And presumably our translators don't need extra work to do :-)
(Also consistency with handling of other similar messages, which are 
not translated...)

Also changed client to not die on unknown packet type, just emit 
LOG_ERROR message and continue (ignoring packet).

(Just a few small changes required to this patch once civserver.c
re-org goes in.)

-- David

use_log_error1a.diff.gz
Description: GNU Zip compressed data