Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2000:
[Freeciv-Dev] Re: 3 suspicous code parts
Home

[Freeciv-Dev] Re: 3 suspicous code parts

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: 3 suspicous code parts
From: Jeff Mallatt <jjm@xxxxxxxxxxxx>
Date: Sun, 06 Aug 2000 15:31:00 -0400

At 2000/08/06 15:09 , Gaute (B) Strokkenes wrote:
>
>uint32_t on my machine.  unsigned long is inappropriate because this
>is an IPv4 address and thus 32 bits.  (long is 64 bits on e.g. alpha.)
>
>The -1 should be changed to INADDR_NONE.  Better yet, use inet_aton()
>instead since 255.255.255.255 is in fact a valid address.

Right.  I'll change my patch before I commit it.

jjm




[Prev in Thread] Current Thread [Next in Thread]