[Freeciv-Dev] Re: Cleanup redundant function fillislandrivers() (PR#409)

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/06/23 23:46 , =?BIG5?B?vbKr7bXY?= wrote:
>
>
>Regards,
>I.Q.
>______________________________________________
>FREE Personalized Email at Mail.com
>Sign up at http://www.mail.com/?sr=signup
>
> 

Well, the functions do different things.  Your "cleanup" doesn't reproduce
existing behavior.

It does get rid of a function that is used only once, and which can be
easily replaced by a call to another existing function.  That's good.

Attached is a patch that does this.  This, too, doesn't *exactly* reproduce
existing behavior -- but is actually arguably more correct.

rivers-fill-3.diff
Description: Text document

jjm