[Freeciv-Dev] patch: server/ai header cleanups (PR#463)

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

This patch makes some minor cleanups, based on looking through 
*.h files in server and ai directories:

Made some functions static where possible and reasonable:
  aicity: ai_manage_city()
  aiunit: ai_manage_military(), ai_manage_caravan(), ai_military_findjob(),
          ai_military_gohome(), ai_military_attack(), unit_move_turns(),
          int unit_can_defend()
  cityhand: remove_trade_route()
  cityturn: advisor_choose_build()
  civserver: check_for_full_turn_done()
  maphand: send_NODRAW_tiles(), map_get_sent(), map_set_sent(), 
           map_clear_sent(), set_unknown_tiles_to_unsent()
  settlers: get_a_name(), city_desirability(), make_dy(), make_dx()
  unitfunc: unit_restore_hitpoints(), unit_restore_movepoints(),
            maybe_make_veteran(), wakeup_neighbor_sentries(),
            do_nuke_tile(), place_partisans()
  unittools: rate_unit_d(), rate_unit_a()

Moved some functions to more appropriate modules:
  unit_attack_desirability() aicity -> advmilitary
  build_points_left() unittools -> citytools
  in_city_radius() settlers -> citytools
  server_player_init() civserver -> plrhand
  show_map_to_all() plrhand -> maphand

Commented out (#ifdef UNUSED) some unused functions:
  aicity: ai_in_initial_expand()
  citytools: better_tile(), eval_buildings()
  settlers.c: locally_zero_minimap()

Removed some declarations of non-existent functions:
  plrhand: handle_player_ai_options(), researchprogress()

-- David

dwp_cleanup.diff.gz
Description: GNU Zip compressed data