[Freeciv-Dev] Re: Units not shown when investigating city. (PR#422)

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/06/27 12:14 , Thue wrote:
>Den tir, 27 jun 2000 skrev Thue:
>> Den tir, 27 jun 2000 skrev Jeff Mallatt:
[snip]
>> > However, there is also a problem with units that are fogged at the moment
>> > the city is investigated -- even if the city is not fogged at the
start of
>> > the turn, if a unit that is supported by the city is fogged when the city
>> > is investigated, that unit does not show up as supported.
[snip]
>Here is a fix; it changes how FoW works in the client, so that units is
>now removed when the tile becomes visible, not when it becomes fogged. As
>far as I can see, and I *think* I can see it all, it doesn't have any
>problems, but it is a bit fundamental! I haven't really tested it yet,
>just thought about what needed to be changed.

This patch does not fix the supported units part of the bug.

I also don't like the "old non-state laying around" approach to fixing
this.  It's kinda scary to me (in addition to problems, like the "occupied
flag", that arise because it's hard to save non-state).  I'd rather see a
solution that directly addresses the real problem.

>Perhaps we should just list the bug in BUGS and apply the fix to the next
>version.

I think this is a fairly serious bug.  However, it may be best to release
1.11 tomorrow without a fix for this, and plan to release a 1.12 bug-fix
release in about a month (a short cycle).

Yes.  I think this is best.  So, unless I hear loud complaints, I'll
declare 1.11 basically done, and start building the final beta in about
three hours.

jjm