[Freeciv-Dev] Re: Diplomat menu popup on goto

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Thue Janus Kristensen <thue@xxxxxxx> wrote:

> Subject: Re: [Freeciv-Dev] [patch] make gotoing diplomats pop 
> up a menu in the client (PR#37) && (PR#306)

> Solves some bug reports (also mentioned on the known bugs page)

> Ummm; not much to say about it :)
> I couldn't resist doing a little cleanup wihle I was at it.

Also:

> I just accidentally thought about it and then it struck me that it would be a
> great feature if it didn't pop up the dialog when I entered one of my own
> cities!

:-)

Some comments:
- Use freelog instead of printf;
- Adding a packet: add capabilities handling!

But the main issue for me is the possibility that the diplmoat goto 
(or rather the arrival) happens between turns.  This means:
- The dialog should identify which city it is;
- Modal dialogs at end-turn are annoying (we have some, but
  IMO shouldn't);
- Multiple dialogs could popup, but the dialog uses some global
  variables so only one of them will work.

Possibiities:
- Keep it simple: ignore extra popup packets if the dialog is
  already up; this solves the most common case of using goto
  intead of the arrow keys.
- Have a queue system like for caravans.
- Rework gui stuff to allow multiple dialogs (nicest).

Regards,
-- David