[Freeciv-Dev] Re: compiler warnings (Sun's cc on 1.10.0) (PR#269)

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/02/22 11:22 , Reinier Post wrote:
>Compiled 1.10.0 (the Xaw client, on an Ultra 10, 64-bits Solaris 7,
>with Sun's own Workshop compiler, cc) and got some warnoings.
>Nothing serious, I suppose, but here they are anyway:

Attached is a patch which fixes some of this...

>"log.c", line 109: warning: end-of-loop code not reached
>"log.c", line 130: warning: end-of-loop code not reached
>"log.c", line 139: warning: end-of-loop code not reached
>"log.c", line 141: warning: end-of-loop code not reached

Help!  I really don't understand the weird FRETURN() macro!?!?

>"aiunit.c", line 1735: warning: statement not reached

Removed extraneous debug log message.

>"dialogs.c", line 1454: warning: assignment type mismatch:
>        pointer to function(pointer to struct _WidgetRec {}, pointer to
char, pointer to char) returning void "=" pointer to void

Added a cast.

>"./../include/freeciv.ico", line 4: warning: initializer does not fit or
is out of range: 128
>"./../include/freeciv.ico", line 4: warning: initializer does not fit or
is out of range: 255
>
>(these go on and on ...)

Damn.  The program I use to generate the icon didn't type it "unsigned".
So, I manually added it.

>"wldlg.c", line 533: warning: argument #2 is incompatible with prototype:
>        prototype: pointer to char : "wldlg.c", line 151
>        argument : pointer to struct worklist_dialog {pointer to struct
_WidgetRec {..} worklist, pointer to struct _WidgetRec {..} avail, poin...

Added a cast.

warnings-cleanup-0.diff
Description: Text document

jjm