[Freeciv-Dev] Re: Duplicated cities - patch against today CVS

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Tomasz Wegrzanowski <maniek@xxxxxxxx> wrote:

> Because last major cityset change made it
> difficult to apply previous patch, Kenyan city
> Hadera is duplicate of Israeli Hadera and
> 2 last duplicates must be solved :
> Cordoba.sp deleted
> Thebae.eg -> Thebes.eg
> I herewith attach patch that solves EVERY
> city duplication.

Ok, but I'm still wondering what the real problem is with
having duplicate city names in nations.ruleset?  

Note that currently the server will skip the names of any 
existing city in its suggestions, but will allow duplicate 
names if the player manually selects a name.  

So effectively the names come out unique already (such that 
the first player to build gets the name), with the bonus that 
uniqueness is only applied for the nations in the game, not 
globally.  (Actually even better: only for those cities which
would actually be built, so e.g. nations which die early don't
count.)

The exception is if players deliberately choose duplicate names,
and your solution doesn't fix that either.  (And I don't think
there are serious problems with actual duplicate named cities, 
just some difficulties with the Find City dialog and similar.)

Regards,
-- David