Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2000:
[Freeciv-Dev] Re: Coredump with latest CVS
Home

[Freeciv-Dev] Re: Coredump with latest CVS

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Coredump with latest CVS
From: Jeff Mallatt <jjm@xxxxxxxxxxxx>
Date: Fri, 04 Feb 2000 11:02:52 -0500

At 2000/02/03 16:32 , Jeff Mallatt wrote:
>So, I was poking around, and while looking at ai_manage_unit(), I noticed
>that after each sub-call (e.g., ai_manage_diplomat(), ai_manage_settler(),
>&c.) the code falls through to another branch of the if/else if/else
>if/else, which tests punit->type for something -- *but* punit may
>potentially be invalid upon return from any of the sub-calls, right?  So, I
>think we need to add 'return;'s after each ai_manage_xxx() call.

Here's a patch which adds these 'return;'s.

Attachment: robust-ai_manage_unit.diff.gz
Description: Binary data

jjm

[Prev in Thread] Current Thread [Next in Thread]