[Freeciv-Dev] Re: [PATCH] Merge of Juha Litola's help dialog and my turns_per_research

[Juha Litola <jlitola@xxxxxxxxx>]

On Mon, Jan 31, 2000 at 11:25:27AM -0500, Jeff Mallatt wrote:
> At 2000/01/29 16:23 , s830@xxxxxxxxx wrote:

> First, it's easier to integrate patches if each patch does one thing.
> Adding number of turns to research to both Tax Rates and Science Report is
> one thing, changing the Help toggle to a Help button could be separate --
> it doesn't have to be, it's a judgement call.  However, in the current case
> the Help button change is much closer to being done than the number of
> turns change.  Tying them together means that I can't commit the Help
> button patch until the number of turns patch is ready.
Third and hopefully last patch included. Just changes toggle-button to
button, no changes to values or text.

> As for problems in the Help button change, while _one_ toggle sufficed, we
> need _two_ buttons -- one to open help onto the Goal and another to open
> help onto the Researching tech.  Also, the popup_help_dialog_active
I don't see need for two help buttons. After help is open, changing
either of lists updates help dialog. This is pretty much equal to checking 
help toggle and then selecting menu item. But toggle was ugly and 
hard to use (at least I got frustrated).

> function is both declared and defined as:
>     int popup_help_dialog_active()
> but, Freeciv is a C program, and we want to use strict prototypes, so if it
> takes no arguments it needs to be declared/defined as:
>     int popup_help_dialog_active(void)
My fault, I mostly code in C++. Fixed in patch.

// Juha Litola

gtk-science-help.diff
Description: Text document