[Freeciv-Dev] Re: Turns left to build in citydlg

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

Great!  This will be very useful.  A few minor things, though...

The default width of the Change Production dialog should now be a little wider, 
to accommodate the " # turns" text.

Capitalization is handled correctly in the city dialog (it does not display the 
# turns left), but in the Change Production dialog, it is shown as having some 
number of turns required to build.

You should internationalize any user-visible string that has translatable words 
in it.  Looking at this patch, it seems only four strings, where you've added 
the word "turn" or "turns", need to be internationalized.  They are all 
arguments to function calls, so just surround each string literal with _().  
E.g.:
   ..., "%s (%d) %d turns", ...
becomes
   ..., _("%s (%d) %d turns"), ...

>>> IMO you should move the calculation stuff to gui independ part.
>>> I attached the function I have done in client/gui-mui/citydlg.c.
>> Yes, perhaps your function should be moved to the common dir?
>
>I think so.

As soon as there's a patch that adds this function, I'll make the Xaw client 
changes.

jjm