[Freeciv-Dev] warmap goto bug

[Corin Anderson <corin@xxxxxxxxxx>]

Hey folks.

  Has anyone else had trouble with making units GOTO and the most recent
CVS build?  When I ask a unit to goto, the server dumps core; it seems
that the warmap hasn't been initialized.  A gdb backtrace in below, as is
a really simple patch to fix the problem.  I notice that the afflicted
code seems to have changed very recently.  Maybe this problem's solution
is already in the works?

Thanks,
Corey


(gdb) bt
#0  0x4006ba5b in memset () from /lib/libc.so.6
#1  0x805910d in init_gotomap (orig_x=17, orig_y=39) at gotohand.c:391
#2  0x80592ab in find_the_shortest_path (pplayer=0x821f0e8, punit=0x823fc20, 
    dest_x=16, dest_y=39) at gotohand.c:432
#3  0x805a43e in do_unit_goto (pplayer=0x821f0e8, punit=0x823fc20)
    at gotohand.c:748
#4  0x8079e57 in handle_unit_goto_tile (pplayer=0x821f0e8, req=0x823fe08)
    at unithand.c:69
#5  0x805388a in handle_packet_input (pconn=0x80d1740, packet=0x823fe08 "e", 
    type=37) at civserver.c:1002
#6  0x806b580 in sniff_packets () at sernet.c:214
#7  0x80529c5 in main (argc=1, argv=0xbffff9e4) at civserver.c:470


diff -c -r1.45 gotohand.c
*** gotohand.c  1999/11/29 20:59:24     1.45
--- gotohand.c  1999/12/01 03:19:48
***************
*** 745,750 ****
--- 745,752 ----
      return;
    }
  
+   generate_warmap(NULL, punit);
+ 
    if(find_the_shortest_path(pplayer, punit, 
                            punit->goto_dest_x, punit->goto_dest_y)) {