[Freeciv-Dev] Re: Server segfaults when click on rates icons (PR#140)

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

qpkjeek@xxxxxxxxxxxxxxx wrote:

> Full_Name: Jerzy Klek
> Version: 1.8.4-beta
> OS: Solaris 2.6

> How to reproduce:
> Start server and client. Connect to the server.
> Click on place where you will later have scientist/taxmen
> icons. Server crashes. Probablu client send select rates 
> packet although game has not started yet.

I think in recent servers this may have changed from a crash
to just a server log message due to addition of more bounds 
checking, but in any case I have checked in a specific fix for 
this: in clients, do nothing in callback unless game is running;
in server also check whether game is running when receive a 
rates packet.

-- David