[Freeciv-Dev] warnings

[Fabrice Noilhan <Fabrice.Noilhan@xxxxxx>]

Hi,
on my Solaris 2.6 box, I had some warnings. Most of them were use
of char instead of `unsigned char' in isalpha and other functions. There
was also:

xmain.c:316: warning: int format, uid_t arg (arg 3)

I made the implicit cast myself. uid_t is a long in POSIX.

and there was an ambiguous else somewhere, I've put brackets according
to the indentation.

I've not tested this intensively, but I've not done anything suspicious.
See the patch below. Maybe shall we use only `unsigned char' instead of
chars in order to do it The Right Way. It may also produce warnings
on other systems now...

        Fabrice

patch
Description: Text document