[Freeciv-Dev] Segmentation fault when diplomat investigates city

[Patrick Smith <patsmith@xxxxxxxxx>]

The client recently crashed on me, with a segmentation fault.

This happened when I sent a diplomat into an enemy city.  The popup
dialog
appeared, I asked to investigate the city, and then the client crashed.

(My first reaction was "Oh no, there must be something wrong with the
diplomat patch I recently submitted.  But this seems not to be the
source
of the problem.  :-))

I think this happens because handle_city_info in client/packhand.c is
not
initializing the city's unit information.  When we later try to display
the city's supported units, the first unit struct in the list seems to
contain reasonable data (on a brief scan by someone unfamiliar with the
code), but the second contains garbage.

I'm not familiar enough with the code to want to try fixing this one
myself,
so perhaps someone else would care to take a look at it?  I can supply
a save file.

This happens with both the Dec 11 CVS version and the Dec 7 version.

Pat
-- 
patsmith@xxxxxxxxx