Re: [Freeciv-Dev] Portability Issues

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Patrick Edson wrote:
> 
> I thought I would mention the small list of things that I have to
> change to make libcivcommon compile on BeOS and some general
> modifications in creating the server/client/common.

Thanks for the comments.  (Patches are welcome too.)

> For libcivcommon:
> 
> Different pointer types:
> packets.c
> Line 230: changed buffer to (char *)buffer (from unsigned char*)
> Line 241: changed buffer to (char *)buffer

Actually, I think we should instead be using memcpy here?

> In general (client/server/common):
> 
> Not everyone has X11:

Well they do if they're compiling the current client.  Obviously
a different target GUI would require appropriate configure changes
too.  For now if you just want to build libcivcommon use
 ./configure --disable-client
(and possibly also --disable-server if you like).


> Not having function prototypes for all functions causes warnings.

Which functions? 

> char[xx] in functions is not MT safe (as opposed to char * and malloc)

Does this cause problems in practice?  It's much more convenient
to use arrays where appropriate rather than malloc everything.

-- David