Re: [Freeciv-Dev] configure.in nitpicking

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Per Mathisen wrote:

> There is no need for AC_SUBST(VERSION) or AC_SUBST(PACKAGE) when you
> use AM_INIT_AUTOMAKE, it is redundant.
> 
> If you remove the -nodefine directive used in AM_INIT_AUTOMAKE,
> you can remove the AC_DEFINE_UNQUOTED(PACKAGE, $PACKAGE) and 
> AC_DEFINE_UNQUTOED(VERSION,$VERSION) lines, as AM_INIT_AUTOMAKE 
> will do exactly the same. I do not understand why the -nodefine directive
> was put there in the first place. Unlike the current configure.in, the
> built in macro defines PACKAGE as "$FREECIV" and not just $FREECIV
> (pay attention to the ""s), the latter being is wrong and breaks gettext.

Thanks, I was wondering about some if these when looking at the
recent configure.in changes.

> IMHO, the new X library check macros are way too complicated. How about
> redefining $LIBS for each OS type instead? Like:
>       AC_CANONICAL_HOST
>       case $host_os in
>               linux*)
>                       LIBS="$LIBS -L/usr/X11/lib -lX11 -lXX -letc"
>               freebsd*)
>                       LIBS="$LIBS -L/usr/weird/place -lX11 -letc"
>               solaris*)
>                       lIBS="$LIBS -L/usr/openwin/sucks -lX10 -letc"
>               *)
>                       LIBS="$LIBS -L/default/place -lX11 -letc"
>       esac

But, doesn't this guarantee failure on particular installations where
our choice for a given os happens to be wrong?

-- David