[Freeciv-Dev] [Patch] Fortress with enhanced vision (watchtower-like)

[Bert Buchholz <bertbuchholz@xxxxxx>]

Hi,

Patch against cvs from Fri, Aug-24, somewhen in the evening :-) 
This is now the watchtower "included" in a fortress, because most people
liked it better this way. First, the features:

Features:
  - The fortress provides a larger visionrange (2), as soon as
    "invention" is invented (can be changed in rulesets)
  - tech_flag_id: TF_WATCHTOWER
  - *flag_names[]: Watchtower
  - Still, fortresses have no owner, just like now, so everybody, who
    steps into a fortress, gets enhanced vision (as long as he stays
    there & he has made the necessary invetion), no matter who built it.
  - If a fortress is empty, no enhanced vision will be granted.
  - Units, that have a visionrange == 2 will get no enhanced sight. This
    means, that they will keep their visionrange of 2.

IMPORTANT: Currently, if there are units with visionrange > 2, their
visionrange is reduced. This is not logical, so maybe the visionrange
shouldn't be set to 2 but enhanced by 1 (vision_range+1), but this would
mean that spies inside a fortress would get a visionrange of 3, which
seems to be very much. In fact, every visionrange > 2 seems to be too
much, but maybe you think diffrently. Also, the value 2 is hardcoded,
maybe that is not desired, even though I don't see too many reasons to
play around with this one, but you never know :-)

Up to now, following events regarding watchtowers are handled (there may
be more to handle which I didn't see):
- A fortress is pillaged (vr reduced)
- A town is built upon a fortress (vr reduced)
- A unit steps into a fortress (vr enhanced)
- A unit steps out of a watchtower (vr reduced)
- The necessary invention is made (all units inside fortresses get
  enhanced vr)
- A fortress is built (all units on that tile get enhanced vr)

So, if anything's missing, or other failures (which are of course
intentional ;-), please tell me and I'll try to kick them out, or you do
that or the devil knows who... :-P

Bert

PS: I included a savegame. You'll see a fortress, not having enhanced
    vision. If you play on till 1540, Invention will be invented, and
    the fortress gets enhanced vision, you can then try its
    capabilities. Hope this worx...

civgame1500.sav.gz
Description: Binary data

fortress_watchtower.diff
Description: Text document