[freeciv-ai] (PR#8778) New settler code

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8778 >

> From: Per Inge Mathisen <per@xxxxxxxxxxx>
> 
> Here is an updated version of the patch. I have tested it, and it works.
> Well, at least for some interpretations of 'works' ;). Coordination
> between settlers wanting to go off-shore and ferries to take them is
> (still) not good.
> 
> I had to turn off ferry-exploring, since this meant no ferries available
> for ferrying anyone until map was fully explored.

I tested it with and without exploring and it seems fine.  The only
problem is a one-turn delay between ferry becoming available and
prospective settlers getting this information.  Can you send me a
savegame where exploring is a problem?

Now to building _new_ ferries.  New code doesn't do that at all and it's
the only thing missing.  Here are some thoughts:

The old system was crude but it worked.  Here are the main features:

1. Inland cities don't even consider building settlers for overseas
   travel.  

2. Coastal cities consider going overseas to settle.  If they choose
   to do so, they look for a boat nearby.  If they don't find it,
   instead of building a settler they start building a boat.

One can also think of a centralized system, where a single function is
run each turn to decide (basing on the number of prospective
passengers both active and in production -- this info is now
available) whether more boats are needed and which cities should build
them.

However, as a first approximation, I want to put a version of the
present system in action.  Then we can introduce modifications: inland
cities will be allowed to build settlers if they find a boat for it.

Present find_ferry is powerful enough, but it might be too heavy.  We
can restrict actual looking for boats to the turn before the
production is finished.  This will lead to losing shields every now
and then but is probably worthwhile.

Eventually, if the centralized system is introduced, it will remove
the necessity for expensive find_ferry-ing for each city.  Cities will
just build settlers if there is a port nearby and the system will make
sure boat are built too.