[freeciv-ai] (PR#8543) AI cannot load transports

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8543 >

> [per - Sun May 02 15:30:10 2004]:
> 
> > [jdorje - Mon Apr 26 04:02:07 2004]:
> > The AI will likely need more changes to work well with the new loading
> > interface.
> 
> What changes?

Well, if we knew what the changes were they'd be easy to make.

However, I suggest the following:

- A consistent AI load/unload method is needed.  Currently one place
uses handle_unit_load while another uses load_unit_onto_transporter. 
The difference is that the latter has no sanity checks.  I'd suggest
adding sanity check assertions to load_unit_onto_transporter.  That way
at least you'll get a useful error message.  But the callers must still
be careful to verify that the load is legal.

- I don't know if any other code still tries to load units by sentrying
them, or unload them by idling them.  I'd suggest grepping the AI code
for SENTRY and IDLE.

jason