Complete.Org: Mailing Lists: Archives: freeciv-ai: September 2003:
[freeciv-ai] (PR#6236) Bug in CM

[freeciv-ai] (PR#6236) Bug in CM

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [freeciv-ai] (PR#6236) Bug in CM
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Mon, 22 Sep 2003 07:39:53 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Sun, 21 Sep 2003, Jason Short wrote:
> > Valgrind gives this fairly often for the server:
> > ==13287==  at 0x8067A58: auto_arrange_workers (cityturn.c:235)
> > Could relate to PR#6222, but I doubt it (this is just an invalid read).
> > This may have been reported before. We really need to fix it.
> The culprit is the worker_positions_used field. In the client this is
> memset to 0 before it is used. In the server it's not.

I don't see why it should be. cm_query_result() shouldn't give us a
cm_result struct with unset data in it. So the bug must be in CM.

I looked at this briefly but found nothing. Raimar?

  - Per

[Prev in Thread] Current Thread [Next in Thread]