[freeciv-ai] Re: AI Diplomacy v8 (PR#2413)

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Tue, Mar 04, 2003 at 03:59:55PM -0800, Per I. Mathisen wrote:
> 
> This is a new version of the AI Diplomacy patch with substantial rewrites
> of some portions of the patch. Thanks to Jordi, Richard and Chris for
> playtesting the previous version (I hope I didn't forget anyone now).
> 
> CHANGES:
>  - treaties now based on trust, not gold alone
>  - allow space victory for team members
>  - make hatred count more
>  - disallow negative hatred
>  - ensure ally patience is correctly zeroed when war declared
>  - if you get a "No" from a human player, don't ask again
>  - fixed insane gold equivalence of techs when there is a huge
> research disparity
>  - fixed many other bugs
>  - you can give the AI gifts, it will like you more (more trust,
>    but hatred remains unchanged)
>  - you can no longer agree with AI to lower your treaty level
>  - lots of other stuff I am sure
> 
> Please playtest. I will now start working on the diplomacy rules that I
> discussed earlier. It will make AI Diplomacy so much more enjoyable.
> 
> Also included is a savegame for testing.

IMHO you make the same error again: hardcoding constants all over the
code. It should be the goal to divide the algorithm from the policy.

Missing i18n.

Nice:

>   /* Count big cities as twice the threat */
>   city_list_iterate(aplayer->cities, pcity) {
>     kill_desire += pcity->size > 8 ? 1 : 0;
>   } city_list_iterate_end;

2*0 == 1???

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 1 + 1 = 3, for large values of 1