[freeciv-ai] Re: Kill_something_with does unnecessary calculation.

[Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>]

Attached is the final cleanup patch for kill_something_with.  It removes masses
of unwanted code, moves some of the code into process_attacker_want.

I am now really bored with this stuff, so this will be the last patch in the
line.  I thought about extracting common components of k_s_w and f_s_t_k, but
they all operate on masses of variables.  I better leave things as they are.

G.


Quoting Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>:

> 
> Now that many bug-fixes were ported from k_s_w to f_s_t_k and back, the
> difference between the claculation done in the two functions is very small. 
> The
> attached patch removed the remaining difference (buggy in part) and
> highlights
> that the calculation of want in k_s_w is not needed.
> 
> This patch is for information only.  I will supply a separate patch removing
> the
> unnecessary code form k_s_w and possibly merging it with
> process_attacker_want.
> 
> Best wishes,
> G.
>

ksw_paw.diff
Description: Text document