[freeciv-ai] Questions on Advdomestic.c

[Jordi Negrevernis i Font <jorneg@xxxxxxxxxxx>]

   In function 'ai_eval_buildings' there are some diferencies in 
dealing with shield bonus improvements:
294   needpower = (city_got_building(pcity, B_MFG) ? 2 :
295               (city_got_building(pcity, B_FACTORY) ? 1 : 0));

400   if (could_build_improvement(pcity, B_FACTORY))
401     values[B_FACTORY] = (prod/2) + pollution_benefit(pplayer, pcity, 
B_FACTORY);
411   if (could_build_improvement(pcity, B_HYDRO) && 
!built_elsewhere(pcity, B_HOOVER))
412     values[B_HYDRO] = ((needpower * prod)/4) + 
pollution_benefit(pplayer, pcity, B_HYDRO);
421   if (could_build_improvement(pcity, B_MFG))
422     values[B_MFG] = ((city_got_building(pcity, B_HYDRO) ||
423                      city_got_building(pcity, B_NUCLEAR) ||
424                      city_got_building(pcity, B_POWER) ||
425                      city_affected_by_wonder(pcity, B_HOOVER)) ?
426                      (prod * 3)/4 : prod/2) +
427                      pollution_benefit(pplayer, pcity, B_MFG);

429   if (could_build_improvement(pcity, B_NUCLEAR))
430     values[B_NUCLEAR] = ((needpower * prod)/4) + 
pollution_benefit(pplayer, pcity, B_NUCLEAR);
494   if (could_build_improvement(pcity, B_RECYCLING))
495     values[B_RECYCLING] = pollution_benefit(pplayer, pcity, 
B_RECYCLING);
   This makes a city with high production without HooverDam begin 
building factory if it does not generate polution. But if it generates 
polution it will not build the factory...
   But will not build the hydroplant or nuclear plant because you don't 
have the factory or manufacturing plant!!!!!
   I say to build happyly factory when you have nuclear plant, hydro 
plant or Hoover Damm.
   I don't remember to see a factory or mfgplant on an invaded ai city 
with high production... i think this will make the ai stronger.