[freeciv-ai] Re: cleanup of AI move and attack handling (PR#1803)

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Wed, 7 Aug 2002, Raimar Falke wrote:
> There are some style issues with this.

Fixed some I found. Please point to 'em if you find more.

> Barbarians are AI. If all AI moves go through the extra function
> ai_move_unit you can handle the expection quite easy.

Good idea. Done.

New patch attached. Also fixes a stupid bug in aiunit.c:ai_military_gohome
which didn't check if target to attack actually was a target or just a
null position from a failed attempt to ai_military_findvictim. Bug found
by adding some stricter assert checking to the new functions. Also moves a
macro into relevant scope in aiunit.c.

Yours
Per

aionlymoveclean2.diff
Description: Text document