[freeciv-ai] Re: Generalised improvements AI support

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, May 06, 2002 at 09:19:45PM +0200, Per I. Mathisen wrote:
> On Mon, 6 May 2002, Ben Webb wrote:
> >     Most of the existing building types now "work" with the impr-gen
> > code.
> 
> Which of the effects do _not_ work, and what remains to be done to make
> them work?
> 
> I know about "Improve_Rep" - it should be removed. Some of the effects
> also need better documentation.
> 
> > However, I haven't touched the AI yet, so presumably it'll still
> > go merrily on its way with its own ideas of what each building does,
> > no matter how you configure your buildings.ruleset. I'm also told, however,
> > that a lot of the code is buggy, so I don't want to waste my time
> > trying to convert it to use impr-gen if it doesn't do anything useful
> > in the first place, or if you're planning to rewrite it soon.
> 
> We should rewrite it, not continue kludging it like Andi did. My immediate
> thoughts about an interface would be something akin to this:
> 
> /** This goes in a Building Evaluation Agent or something **/

> /* Create a virtual city out of pcity.

I'm not a friend of this approach. It is neither very clean (you just
don't which field are used and which fields needs initializing) nor
does it extend very good (since you don't know which fields are used
you have to set them all). I know that the other approach (passing all
the required field as parameter or in a struct) is also not this
nice. But it is cleaner.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Your mail could not be delivered to the following Address:
  VTCMC.VTLPR@xxxxxxxxxxxxx        ** Unassigned error message **"