[freeciv-ai] Review of AI_can_fly 2

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

Review: Ai_can_fly 2
Type: Code Review

The patch is too big. It needs to be split into smaller sections consisting of
at least

1.) adjust_ai_attacker_choice, the changes to the want equations, the changes
that permit the ai to build airports/air units etc -> Vote for CVS inclusion,
(Note: there are dependencies on virtual unit code.)

2.) A priority queue implementation

3.) Ruleset changes, including flags TF_AIRBORNE -> Vote for CVS inclusion.

4.) Everything else

Highlight: Greg's changes to advmilitary.c, including
adjust_ai_attacker_choice, choice->want. These are the highlights of the patch.


I also like is_stack_vulnerable (Nice to have it respect killstack). 

ai_evaluate_tile_for_attack is The Right Way to evaluate a tile for attacking.
It could easily be extended to support ground/sea units as well.

Aloha,
RK.

Never send a monster to do the work of an evil genius. 

__________________________________________________
Do You Yahoo!?
Yahoo! Tax Center - online filing with TurboTax
http://taxes.yahoo.com/