[freeciv-ai] AI part of the corecleanups

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

Attached is Ross's cleanup minus everything else. This is just the AI bits. I'm
going to send in various bits of the patch in this email as individual patches.
Note: I will only send in the bits I like.

I've been reading Ross's corecleanups, and I like some bits of it. I like his
use of case statements instead of ugly nested multiple ifs. I think the code he
wrote in to make sure that settlers don't keep building in a city is good, and
the idea of making sure that the AI doesn't keep flip flopping from one build
item to the next is great.

I also like the fact that he got rid of an unnecessary wrapper.

There are other bits I am very lukewarm about or downright hate. 

I've split the AI bits apart from the rest. I want your input on what you
like/dislike about it.

Per: Ross has implemented ocean code! I want you to split it from the rest of
his cleanups and send it in as a patch.


Aloha,
RK.

Math is like love -- a simple idea but it can get complicated.
-- R. Drabek

__________________________________________________
Do You Yahoo!?
Yahoo! Tax Center - online filing with TurboTax
http://taxes.yahoo.com/

-- Binary/unsupported file stripped by Ecartis --
-- Type: application/x-gzip
-- File: rossai.diff.gz
-- Desc: rossai.diff.gz