[Freeciv-Dev] Re: (PR#9818) Inland lakes and borders

["Mateusz Stefek" <mstefek@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9818 >

Dnia 2004-08-30 23:22:16, Gregory Berkolaiko napisał(a):
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9818 >
> 
> > Any more objections to this patch? If no, I will commit it  
> tommorow.
> 
> The patch seems ok.  Why did you make get_continent_size() and
> get_ocean_size() functions if you don't use them.

Marcelo needs these functions in his patches.

> It's fine by me,
> compiler will kill them, but maybe others will object.  Well, at  
> least
> you
> can use get_ocean_size instead of
>       ocean_sizes[-cont] <= MAXIMUM_CLAIMED_OCEAN_SIZE

good point


> Also, all these negative array indeces look ugly, maybe we can invent
> something to incapsulate the negativeness.  like get_ocean_number.
> but it might cause even more ugliness...
> Anyway, it's a subject for a different patch.
> 
> G.
>
Yes. This system is bug-prone. (As seen in PR#9877). I'm going to fix  
it somehow later.
--
mateusz


----------------------------------------------------------------------
Startuj z INTERIA.PL!!! >>> http://link.interia.pl/f1830